Consider changing subforum routes to /board/:id instead of just /:id #17

Closed
opened 2024-08-20 03:49:36 +00:00 by nu · 0 comments
Owner

Changing the subforum ID scheme to an imageboard-esque one in commit 44eeaa80e6 (as per #7) introduced a bug wherein any routes listed below the subforum-related routes would be interpreted as though it was supposed to be a subforum view route, with the first example I encountered being the /logout route being treated like you were trying to view a subforum with the name logout. I fixed this in commit f10dab805a by moving the subforum-related routes below all other routes, but this feels hacky! Thus I think the subforum-related routes should be changed to something akin to /board/:id

Changing the subforum ID scheme to an imageboard-esque one in commit 44eeaa80e6 (as per #7) introduced a bug wherein any routes listed below the subforum-related routes would be interpreted as though it was supposed to be a subforum view route, with the first example I encountered being the `/logout` route being treated like you were trying to view a subforum with the name `logout`. I fixed this in commit f10dab805a by moving the subforum-related routes below all other routes, but this feels hacky! Thus I think the subforum-related routes should be changed to something akin to `/board/:id`
nu added the
improvement
code clarity
labels 2024-08-20 03:49:36 +00:00
nu closed this issue 2024-08-21 04:31:17 +00:00
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: nu/CharmBoard#17
No description provided.