Stop using smartmatch `~~`

nu commented

2024-08-19 08:07:28 +00:00

Owner

I don't think it does what I thought it did back when I started using it, so it'd be better to just... Not.

nu added this to the CharmBoard v1.0 milestone 2024-08-19 08:07:28 +00:00

nu added the

improvement

label 2024-08-19 08:07:28 +00:00

nu commented

2024-08-19 08:07:34 +00:00

Author

Owner

For, i.e. the database type checker, it might be better to force lowercase the config value before comparing it, so if someone types SQLite in the config instead of sqlite then it doesn't die unnecessarily. I believe this is what I intended when deciding to use smartmatch here.

For, i.e. the database type checker, it might be better to force lowercase the config value before comparing it, so if someone types `SQLite` in the config instead of `sqlite` then it doesn't die unnecessarily. I believe this is what I intended when deciding to use smartmatch here.

nu commented

2024-08-19 08:08:24 +00:00

Author

Owner

For, i.e. the database type checker, it might be better to force lowercase the config value before comparing it, so if someone types SQLite in the config instead of sqlite then it doesn't die unnecessarily. I believe this is what I intended when deciding to use smartmatch here.

For, i.e. the database type checker, it might be better to force lowercase the config value before comparing it, so if someone types `SQLite` in the config instead of `sqlite` then it doesn't die unnecessarily. I believe this is what I intended when deciding to use smartmatch here.

nu commented

2024-08-19 08:11:24 +00:00

Author

Owner

Yeah... That's literally the only place I was using smartmatch. Now to go through and change each use experimental qw(try smartmatch); line to just use experimental qw(try); in every. single. PM file.

Yeah... That's literally the only place I was using smartmatch. Now to go through and change each `use experimental qw(try smartmatch);` line to just `use experimental qw(try);` in every. single. PM file.

nu referenced this issue from a commit

2024-08-19 08:14:18 +00:00

Stop using smartmatch (#15) and add 5.20 features (part of #13)

nu closed this issue

2024-08-19 08:14:28 +00:00

nu referenced this issue

2024-08-19 18:10:50 +00:00

Figure out which Perl versions CharmBoard works with #13

Stop using smartmatch ~~ #15

Stop using smartmatch `~~` #15